Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate Driver Install Experience within nidaqmx Module for Linux OS #582

Merged
merged 55 commits into from
Jun 29, 2024
Merged

Automate Driver Install Experience within nidaqmx Module for Linux OS #582

merged 55 commits into from
Jun 29, 2024

Conversation

dharaniprakashkm
Copy link
Collaborator

@dharaniprakashkm dharaniprakashkm commented May 15, 2024 •
edited by zhindes
Loading

What does this Pull Request accomplish?

1. Provides a command line python interface to install NI-DAQmx Software for Linux Platform.
2. Checks for existing installation of DAQmx , If DAQmx Software is not installed then it will download the latest installer from ni.com and will launch the installation commands in an interactive mode.
3. If DAQmx Software is already installed then it will compare the installed version with latest available version on the server and prompts for user confirmation on whether they want to upgrade to the latest version or not.

Why should this Pull Request be merged?

We need to install the NI-DAQmx Driver to have Python library functional.
This script will improve the driver install experience for Linux Users.

What testing has been done?

Verified the script works fine on all the NI supported Linux distributions.

zhindes
zhindes requested changes May 15, 2024
View reviewed changes
generated/nidaqmx/_install_daqmx.py Outdated Show resolved Hide resolved
generated/nidaqmx/_install_daqmx.py Outdated Show resolved Hide resolved
generated/nidaqmx/_install_daqmx.py Outdated Show resolved Hide resolved
zhindes
zhindes requested changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much much better, thank you!

src/handwritten/_linux_installation_commands.py Outdated Show resolved Hide resolved
src/handwritten/_linux_installation_commands.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
bkeryan
bkeryan requested changes May 29, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
src/handwritten/_install_daqmx.py Outdated Show resolved Hide resolved
bkeryan
bkeryan reviewed May 29, 2024
View reviewed changes
poetry.lock Show resolved Hide resolved
bkeryan
bkeryan reviewed Jun 27, 2024
View reviewed changes
poetry.lock Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
poetry.lock Show resolved Hide resolved
bkeryan
bkeryan requested changes Jun 27, 2024
View reviewed changes
poetry.lock Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
@zhindes zhindes self-requested a review June 28, 2024 01:00
mshafer-NI
mshafer-NI reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@mshafer-NI mshafer-NI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm realizing I commented on the "generated" files, but please apply the changes to the "handwritten" files)

generated/nidaqmx/_install_daqmx.py Show resolved Hide resolved
generated/nidaqmx/_linux_installation_commands.py Outdated Show resolved Hide resolved
mshafer-NI
mshafer-NI reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@mshafer-NI mshafer-NI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@bkeryan bkeryan closed this Jun 28, 2024
@bkeryan bkeryan reopened this Jun 28, 2024
@dharaniprakashkm dharaniprakashkm merged commit a133d74 into ni:master Jun 29, 2024
16 checks passed
@WayneDroid WayneDroid mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshafer-NI mshafer-NI mshafer-NI left review comments

@bkeryan bkeryan bkeryan approved these changes

@zhindes zhindes zhindes approved these changes

@maxxboehme maxxboehme maxxboehme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dharaniprakashkm @maxxboehme @bkeryan @mshafer-NI @zhindes