Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update AO examples #570

Merged
merged 13 commits into from
May 31, 2024

Conversation

WayneDroid
Copy link
Collaborator

What does this Pull Request accomplish?

  • renamed exisiting AO examples
  • added finite and continuous examples

Why should this Pull Request be merged?

Add AO examples for release 1.0.

What testing has been done?

run poetry run pytest tests/ -q - pass

image

examples/analog_out/cont_gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_sample.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_sample.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/cont_gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/cont_gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/cont_gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/analog_out_helper.py Outdated Show resolved Hide resolved
examples/analog_out/analog_out_helper.py Outdated Show resolved Hide resolved
examples/analog_out/analog_out_helper.py Outdated Show resolved Hide resolved
examples/analog_out/cont_gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/voltage_update.py Outdated Show resolved Hide resolved
examples/analog_out/gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
examples/analog_out/voltage_update.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion: delete types from the docstring

examples/analog_out/cont_gen_voltage_wfm_int_clk.py Outdated Show resolved Hide resolved
@WayneDroid WayneDroid merged commit 860d840 into ni:master May 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants