Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Task Internal Modules: Channels #544

Merged

Conversation

charitylxy
Copy link
Collaborator

@charitylxy charitylxy commented Mar 19, 2024

What does this Pull Request accomplish?

This PR aims to address issue brought up in #461:

  • Currently, task subobject types are defined in internal modules contained in private nidaqmx._task_modules package.
  • We want to turn task.py into a package and merge it with the internal modules contained in nidaqmx._task_modules

Refactoring work will be split into 5 PRs:

Why should this Pull Request be merged?

In this PR to address #461, following changes have been made:

  • Moved channels to task package and made its modules private.
  • Imported the updated metadata from grpc-device-scrapigen to have the new module name documented.
  • Documentation updated
  • tests/component/_task_modules renamed to tests/component/task.
  • Modified the affected module names in tests.

What testing has been done?

Ran poetry run pytest and all tests passed.

@charitylxy charitylxy marked this pull request as ready for review March 19, 2024 02:39
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer to Brad

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

src/codegen/metadata/attributes.py Show resolved Hide resolved
@charitylxy charitylxy merged commit 2e0e590 into ni:master Mar 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants