renovate: Fix Git submodule scheduling #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
dixonjoel,
aepete and
jasonmreding
as code owners
1 task
bkeryan
commented
Aug 30, 2024
jasonmreding
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
The previous scheduling config was not working because
third_party/ni-apisis adepName, not apackageName.At one point,
matchPackageNamesused to match against dep names, but this behavior has been removed. renovatebot/renovate#25233Enable "Dependency Dashboard Approval", which prevents Renovate from creating a PR until someone approves via the Dependency Dashboard.
Why should this Pull Request be merged?
Disable Renovate PRs for Git submodules unless approved via the Dependency Dashboard.
What testing has been done?
When I made the same change in another repo, I checked the Renovate log and verified that it listed the right schedule info.
"Dependency Dashboard Approval" is untested.