Merge branch 'main' into async-rule-changes

ni · Sep 26, 2024 · ff91505 · ff91505
2 parents 003b132 + c2cd58d
commit ff91505
Show file tree

Hide file tree

Showing 12 changed files with 91 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/eslint-config-angular/CHANGELOG.json b/packages/eslint-config-angular/CHANGELOG.json
@@ -1,6 +1,21 @@
 {
   "name": "@ni/eslint-config-angular",
   "entries": [
+    {
+      "date": "Thu, 26 Sep 2024 17:15:21 GMT",
+      "version": "8.1.0",
+      "tag": "@ni/eslint-config-angular_v8.1.0",
+      "comments": {
+        "minor": [
+          {
+            "author": "beachball",
+            "package": "@ni/eslint-config-angular",
+            "comment": "Bump @ni/eslint-config-typescript to v4.3.0",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
     {
       "date": "Thu, 08 Aug 2024 22:33:17 GMT",
       "version": "8.0.1",

diff --git a/packages/eslint-config-angular/CHANGELOG.md b/packages/eslint-config-angular/CHANGELOG.md
@@ -1,9 +1,17 @@
 # Change Log - @ni/eslint-config-angular
 
-This log was last generated on Thu, 08 Aug 2024 22:33:17 GMT and should not be manually modified.
+This log was last generated on Thu, 26 Sep 2024 17:15:21 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 8.1.0
+
+Thu, 26 Sep 2024 17:15:21 GMT
+
+### Minor changes
+
+- Bump @ni/eslint-config-typescript to v4.3.0
+
 ## 8.0.1
 
 Thu, 08 Aug 2024 22:33:17 GMT

diff --git a/packages/eslint-config-angular/package.json b/packages/eslint-config-angular/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ni/eslint-config-angular",
-  "version": "8.0.1",
+  "version": "8.1.0",
   "description": "NI's Angular ESLint Shareable Config",
   "main": "index.js",
   "scripts": {
@@ -37,6 +37,6 @@
     "@angular-eslint/eslint-plugin-template": "^17.5.2",
     "@angular-eslint/schematics": "^17.5.2",
     "@angular-eslint/template-parser": "^17.5.2",
-    "@ni/eslint-config-typescript": "^4.2.2"
+    "@ni/eslint-config-typescript": "^4.3.0"
   }
 }
diff --git a/packages/eslint-config-playwright/CHANGELOG.json b/packages/eslint-config-playwright/CHANGELOG.json
@@ -1,6 +1,21 @@
 {
   "name": "@ni/eslint-config-playwright",
   "entries": [
+    {
+      "date": "Thu, 26 Sep 2024 17:15:21 GMT",
+      "version": "1.1.0",
+      "tag": "@ni/eslint-config-playwright_v1.1.0",
+      "comments": {
+        "minor": [
+          {
+            "author": "beachball",
+            "package": "@ni/eslint-config-playwright",
+            "comment": "Bump @ni/eslint-config-typescript to v4.3.0",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
     {
       "date": "Fri, 10 May 2024 22:42:13 GMT",
       "version": "1.0.3",

diff --git a/packages/eslint-config-playwright/CHANGELOG.md b/packages/eslint-config-playwright/CHANGELOG.md
@@ -1,9 +1,17 @@
 # Change Log - @ni/eslint-config-playwright
 
-This log was last generated on Fri, 10 May 2024 22:42:13 GMT and should not be manually modified.
+This log was last generated on Thu, 26 Sep 2024 17:15:21 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 1.1.0
+
+Thu, 26 Sep 2024 17:15:21 GMT
+
+### Minor changes
+
+- Bump @ni/eslint-config-typescript to v4.3.0
+
 ## 1.0.3
 
 Fri, 10 May 2024 22:42:13 GMT

diff --git a/packages/eslint-config-playwright/package.json b/packages/eslint-config-playwright/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ni/eslint-config-playwright",
-  "version": "1.0.3",
+  "version": "1.1.0",
   "description": "NI's Playwright ESLint Shareable Config",
   "main": "index.js",
   "scripts": {
@@ -31,7 +31,7 @@
     "!/.*.js"
   ],
   "peerDependencies": {
-    "@ni/eslint-config-typescript": "^4.2.2",
+    "@ni/eslint-config-typescript": "^4.3.0",
     "eslint-plugin-playwright": "^0.12.0"
   }
 }
diff --git a/packages/eslint-config-typescript/CHANGELOG.json b/packages/eslint-config-typescript/CHANGELOG.json
@@ -1,6 +1,21 @@
 {
   "name": "@ni/eslint-config-typescript",
   "entries": [
+    {
+      "date": "Thu, 26 Sep 2024 17:15:21 GMT",
+      "version": "4.3.0",
+      "tag": "@ni/eslint-config-typescript_v4.3.0",
+      "comments": {
+        "minor": [
+          {
+            "author": "[email protected]",
+            "package": "@ni/eslint-config-typescript",
+            "commit": "bd1f97ecbc162826266d4f0bef9ea336e31deb8c",
+            "comment": "Disable `@typescript-eslint/explicit-member-accessibility` for constructors"
+          }
+        ]
+      }
+    },
     {
       "date": "Wed, 10 Apr 2024 17:56:39 GMT",
       "version": "4.2.2",

diff --git a/packages/eslint-config-typescript/CHANGELOG.md b/packages/eslint-config-typescript/CHANGELOG.md
@@ -1,9 +1,17 @@
 # Change Log - @ni/eslint-config-typescript
 
-This log was last generated on Wed, 06 Mar 2024 19:12:39 GMT and should not be manually modified.
+This log was last generated on Thu, 26 Sep 2024 17:15:21 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 4.3.0
+
+Thu, 26 Sep 2024 17:15:21 GMT
+
+### Minor changes
+
+- Disable `@typescript-eslint/explicit-member-accessibility` for constructors ([email protected])
+
 ## 4.2.2
 
 Wed, 06 Mar 2024 19:12:39 GMT

diff --git a/packages/eslint-config-typescript/index.js b/packages/eslint-config-typescript/index.js
@@ -74,9 +74,12 @@ module.exports = {
         /*
             Requiring an accessibility modifier helps when creating classes to ensure the
             accessibility of a class member is intentionally decided and not relying on
-            the default of public accessibility.
+            the default of public accessibility. Constructors are omitted because they are
+            almost always public.
         */
-        '@typescript-eslint/explicit-member-accessibility': 'error',
+        '@typescript-eslint/explicit-member-accessibility': ['error',
+            { accessibility: 'explicit', overrides: { constructors: 'off' } }
+        ],
 
         /*
             All interface members should be terminated with a semicolon including single line

diff --git a/packages/eslint-config-typescript/package.json b/packages/eslint-config-typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ni/eslint-config-typescript",
-  "version": "4.2.2",
+  "version": "4.3.0",
   "description": "NI's TypeScript ESLint Shareable Config",
   "main": "index.js",
   "scripts": {

diff --git a/tests/typescript/index.ts b/tests/typescript/index.ts
@@ -3,6 +3,10 @@
 export class NI {
     private _awesomeLevel = 1;
 
+    constructor() {
+        this._awesomeLevel = 11;
+    }
+
     public get awesome(): boolean {
         return this._awesomeLevel > 0;
     }