Store browser sessions in database #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use this Gem to store sessions in the database allowing for more than 4 KB of data, which is useful now that we're starting to create consents and vaccination records in the session.
This adds a new table which we'll use to store sessions backed by ActiveRecord rather than cookies, allowing us to hold data larger than 4 KB.
This allows us to store more data in the session than the 4 KB limit of the cookie store, which might be useful particularly as we're starting to create draft consents and vaccination records in the session.
This mimicks the behaviour of a Rake task which automatically removes old sessions from our database. We want to run this on a schedule and using a job seemed like the easiest way to do it.
|
|
Somewhere, maybe the SLSP, we documented that we store data on the client browser in the cookie, and had to explain that it's encrypted, etc. Gotta love over-documentation. |
tvararu
approved these changes
Nov 18, 2024
benilovj
requested changes
Nov 18, 2024
benilovj
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the session store to use an Active Record one, allowing us to store more data in the session than the cookie store allows us to.
Although we're not seeing problems at the moment, I think it's worth doing now as we're starting to create draft vaccination records and consents in the session, there's a risk the cookie will get too big.