Ensure self-consent triages are invalidated #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
approved these changes
Nov 17, 2024
This was missed in d62ed3d to cover the situation where a session has been closed, self-consents have been invalidated and therefore any associated triages must be invalidated too. If we encounter a similar bug it might be worth refactoring this code to handle the invalidation in the consent model rather than in the controllers. I also think it's worth adding a feature test for this in the future.
thomasleese
force-pushed
the
fix-triage-bug
branch
from
ba1cb86
to
956cc9a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in d62ed3d to cover the situation where a session has been closed, self-consents have been invalidated and therefore any associated triages must be invalidated too.
If we encounter a similar bug it might be worth refactoring this code to handle the invalidation in the consent model rather than in the controllers.
I also think it's worth adding a feature test for this in the future.