Allow env var to change use-path-style param of s3 config #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarrosop
reviewed
May 14, 2024
dbarrosop
reviewed
May 14, 2024
|
Hi, thanks for the contribution, a couple of minor comments. |
bestmazzo
force-pushed
the
feat/usepathstyle
branch
2 times, most recently
from
0476733
to
3d8e6e8
Compare
bestmazzo
force-pushed
the
feat/usepathstyle
branch
from
3d8e6e8
to
9fbdf49
Compare
|
Hello, I've rebases PR based on updated main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in #208 there may be scenarios where s3 storage is configured with a subdomain structure ( ://{bucket_name}.{region}.provider.com ) instead of a path structure ( ://{region}.provider.com/{bucket_name} )
hasura-storage should be able to work accordingly, but we need to extend config params
Problem
So far hasura-storage ENV vars doesn't address this kind of s3 url structure description
Solution
We should see whether passing a ENV_USE_PATH_STYLE variable to s3 config options is enough