Asm7 java10and11 #54
Open
Asm7 java10and11 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library is split in multiple jars since 6.x. This requires some changes in the build description.
This is required to make the 'ant test' tests pass.
|
I am using JDK 11. I applied your patches. The default compilation fails when building the javadoc jars. |
This is no regression. The previous version also triggered 8 errors and 1 warning with JDK8, when building the documentation. |
|
Could that be merged to keep this project usable for newer Java settings? |
|
Is this project still alive? |
|
Hey!!! please merge, need java 1.8 too... |
|
@nhatminhle May I ask whether you see these notifications? We would "just" ask you to merge this pull request. |
|
@miasma Is this project dead? 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to ASM7 jars. Should fix issues with Java 10 and 11. Tested (ant test) with OpenJDK 8,10, and 11.