fix: dump bug because JSON.parse("") throw error instead of null.

nhannht · Jul 3, 2024 · bb8f8d7 · bb8f8d7
1 parent 7e114a3
commit bb8f8d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/GanttBlockManager.tsx b/src/GanttBlockManager.tsx
@@ -13,7 +13,12 @@ export default class GanttBlockManager {
 		this.thisPlugin.registerMarkdownCodeBlockProcessor("gantt", async (source, el, _ctx) => {
 			//@ts-ignore
 			// console.log(_ctx.getSectionInfo(_ctx.el))
-			const settings: SmartGanttSettings = JSON.parse(source)
+			console.log(source)
+			const settings: SmartGanttSettings =source.trim() !== "" ?  JSON.parse(source) : {
+			doneShowQ: true,
+			todoShowQ: true,
+			pathListFilter: ["AllFiles"]
+		}
 			// console.log(settings)
 			// console.log(allSentences)
 

diff --git a/src/SmartGanttBlockReactComponent.tsx b/src/SmartGanttBlockReactComponent.tsx
@@ -15,11 +15,7 @@ export const SmartGanttBlockReactComponent = (props: {
 	settings: SmartGanttSettings
 }) => {
 	const [internalSettings, setInternalSettings] =
-		useState<SmartGanttSettings>(props.settings ? structuredClone(props.settings) : {
-			doneShowQ: true,
-			todoShowQ: true,
-			pathListFilter: ["AllFiles"]
-		})
+		useState<SmartGanttSettings>(structuredClone(props.settings))
 	const [isSettingQ, setIsSettingQ] = useState(false)
 	const [craft, setCraft] = useState("")
 	const [resultWithChronoCount, setResultWithChronoCount] = useState(0)