-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): setup unhandled error handler during NGXS initialization #2263
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 96c181d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +539B +0.41% Groups updated (2)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (3)
Total files change +65B +0.03% Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is more of a fix than a refactor.
It is subtly changing the behaviour (the timing) of this initialisation.
So I would think that the previous timing was not ideal, and the new timing is better.
c507759
to
f36b3cb
Compare
In this commit, we override the RxJS `config.onUnhandledError` within the root store initializer, but only after other code has already executed. If users have a custom `config.onUnhandledError`, we might overwrite it too early and capture the original `config.onUnhandledError` before it is properly set.
0a9ea2b
to
96c181d
Compare
Code Climate has analyzed commit 96c181d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
In this commit, we override the RxJS
config.onUnhandledError
within the root store initializer,but only after other code has already executed.
If users have a custom
config.onUnhandledError
, we might overwrite it tooearly and capture the original
config.onUnhandledError
before it is properly set.