-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add support for standalone APIs in schematics #2060
feat(store): add support for standalone APIs in schematics #2060
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8762ca9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Unchanged files (1)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
57bf906
to
31c1710
Compare
31c1710
to
37f6aec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitry-stepanenko There has been a large drop on test coverage in this PR. I think that this is a result of the code that was copied across.
Please could you either add some tests (maybe if there are some tests to copy too), or find a way to exclude these folders from the test coverage metrics.
f37d561
to
3612a50
Compare
3612a50
to
db60efa
Compare
@markwhitfeld I've excluded the utils folder in |
db60efa
to
a91ad65
Compare
Code Climate has analyzed commit 8762ca9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 72.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (-0.5% change). View more on Code Climate. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Adding support for standalone APIs in schematics
With this PR
ng-add
will be able to add NGXS plugins both to root module as modules and to app.config as provider functions.Please note that there's a new folder
packages/store/schematics/src/utils/ng-utils
. It contains files that were copied from the@schematics/[email protected]
package. It contains very convenient utils that allow adding declarations both in standalone and regular Angular apps. There's no point to reinvent the bicycle and try to implement that functionality ourselves as we will be able to use them directly from@schematics/angular
as we'll start to support the v17 as the minimum required version.Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information