Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add standalone features #1999

Merged
merged 3 commits into from
Aug 27, 2023
Merged

feat(store): add standalone features #1999

merged 3 commits into from
Aug 27, 2023

Conversation

arturovt
Copy link
Member

No description provided.

@arturovt arturovt force-pushed the feat/standalone-features branch 4 times, most recently from a1aa6db to bff3f4a Compare April 23, 2023 19:43
Carniatto
Carniatto reviewed Apr 24, 2023
View reviewed changes
packages/form-plugin/src/form.module.ts

@NgModule({
imports: [ReactiveFormsModule],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this import be moved to the directive imports?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, since this is a directive and we're not using any of the ReactiveFormsModule exports (like [formControl] or any other directive)

@kuncevic
Copy link
Member

great work @arturovt, looking forward that feature to became available at least in preview to be able to play around with that, as spoken to @Carniatto //cc @markwhitfeld

@arturovt arturovt changed the base branch from v-next to master July 7, 2023 20:15
@arturovt arturovt changed the base branch from master to v-next July 7, 2023 20:15
@arturovt arturovt force-pushed the feat/standalone-features branch 13 times, most recently from c5f037c to 1b91e5a Compare July 9, 2023 10:52
@arturovt arturovt marked this pull request as ready for review July 9, 2023 10:54
@ngxs ngxs deleted a comment from nx-cloud bot Jul 9, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 9, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c2c1e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@arturovt arturovt force-pushed the feat/standalone-features branch 6 times, most recently from 3fc474b to bf83224 Compare July 11, 2023 15:06
@arturovt arturovt force-pushed the feat/standalone-features branch 3 times, most recently from 42f6b78 to 19b3d8b Compare July 26, 2023 15:52
@markwhitfeld
Copy link
Member

@arturovt The failing bundlemon check is not about bundlemon limits, but rather some artifacts that are missing:
image

@bundlemon
Copy link

bundlemon bot commented Aug 9, 2023

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
 +63.95KB +1%

Total files change +63.95KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@arturovt arturovt merged commit d522732 into v-next Aug 27, 2023
@arturovt arturovt deleted the feat/standalone-features branch August 27, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carniatto Carniatto Carniatto left review comments

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arturovt @kuncevic @markwhitfeld @Carniatto