feat: add @ngneat/helipopper/config
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arturovt
force-pushed
the
feat/config-lib
branch
from
172f234 to
d79528a
Compare
In this commit, we add a new subpackage called `@ngneat/helipopper/config`. This change is intended to separate configuration logic from UI-related functionality. The configuration should be imported at the root level, while the UI components should only be imported when necessary. Previously, importing the library at the root level (when providing the configuration) caused the bundler to include everything in the main bundle immediately. With this approach, the configuration is bundled separately at the root level and includes only the provider functions. Additionally, while we had already added a `loader` function, to avoid breaking the `provideTippyConfig` signature, we introduced a separate function called `provideTippyLoader`, which exclusively accepts a loader function. The `provideTippyConfig` has been reverted to return a provider (not an environment provider), becuase it might be provided at the component level too.
arturovt
force-pushed
the
feat/config-lib
branch
from
d79528a to
fe59df7
Compare
NetanelBasal
approved these changes
Nov 20, 2024
|
@NetanelBasal could you merge? I'll make a next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add a new subpackage called
@ngneat/helipopper/config.This change is intended to separate configuration logic from UI-related functionality.
The configuration should be imported at the root level, while the UI components should
only be imported when necessary. Previously, importing the library at the root
level (when providing the configuration) caused the bundler to include everything in the
main bundle immediately.
With this approach, the configuration is bundled separately at the root level and
includes only the provider functions.
Additionally, while we had already added a
loaderfunction, to avoid breaking theprovideTippyConfigsignature, we introduced a separate function calledprovideTippyLoader,which exclusively accepts a loader function.
The
provideTippyConfighas been reverted to return a provider (not an environment provider),becuase it might be provided at the component level too.