Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace glog in metrics & telemetry packages #6587

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 3, 2024

Proposed changes

Replace glog with slog in metrics & telemetry packages for:

  • metrics/collectors/latency.go
  • metrics/collectors/processes.go
  • metrics/listener.go
  • metrics/syslog_listener.go
  • telemetry/collector.go

NOTE:

GLog Levels Slog Levels
glog.V(3).Infof() log.Debugf()
glog.V(3).Info() log.Debug()
glog.V(2).Infof() log.Debugf()
glog.V(2).Info() log.Debugf()
glog.Infof() log.Infof()
glog.Info() log.Info()
glog.Warningf() log.Warnf()
glog.Warning() log.Warn()
glog.Errorf() log.Errorf()
glog.Error() log.Error()
glog.Fatalf() log.Fatalf()
glog.Fatal() log.Fatal()

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner October 3, 2024 15:39
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 3, 2024
@AlexFenlon
Copy link
Contributor

nil pointer for tests in collector_test.go - specifically anything that uses CollectorConfig

so please add "Context: context.Background(), " to each CollectorConfig to fix this issue.

@AlexFenlon AlexFenlon mentioned this pull request Oct 4, 2024
13 tasks
@AlexFenlon AlexFenlon added the skip changelog Pull requests that don't need to be added to the changelog label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code skip changelog Pull requests that don't need to be added to the changelog
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

3 participants