Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace glog in the nginx package #6585

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 3, 2024

Proposed changes

Replace glog with slog in configs package for:

  • manager.go
  • fake_manager.go
  • utils.go
  • verify.go

NOTE:

GLog Levels Slog Levels
glog.V(3).Infof() log.Debugf()
glog.V(3).Info() log.Debug()
glog.V(2).Infof() log.Debugf()
glog.V(2).Info() log.Debugf()
glog.Infof() log.Infof()
glog.Info() log.Info()
glog.Warningf() log.Warnf()
glog.Warning() log.Warn()
glog.Errorf() log.Errorf()
glog.Error() log.Error()
glog.Fatalf() log.Fatalf()
glog.Fatal() log.Fatal()

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner October 3, 2024 13:57
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 3, 2024
@pdabelf5 pdabelf5 self-assigned this Oct 3, 2024
@pdabelf5 pdabelf5 linked an issue Oct 3, 2024 that may be closed by this pull request
@pdabelf5 pdabelf5 linked an issue Oct 3, 2024 that may be closed by this pull request
13 tasks
@pdabelf5 pdabelf5 removed a link to an issue Oct 3, 2024
13 tasks
@AlexFenlon AlexFenlon mentioned this pull request Oct 3, 2024
13 tasks
@pdabelf5 pdabelf5 added the skip changelog Pull requests that don't need to be added to the changelog label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 2.01342% with 146 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (89dbaa6) to head (68b0486).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 76 Missing ⚠️
internal/nginx/fake_manager.go 0.00% 58 Missing ⚠️
internal/nginx/utils.go 0.00% 8 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 3 Missing ⚠️
internal/nginx/verify.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6585      +/-   ##
==========================================
+ Coverage   53.07%   53.20%   +0.13%     
==========================================
  Files          87       87              
  Lines       16218    16238      +20     
==========================================
+ Hits         8607     8639      +32     
+ Misses       7203     7187      -16     
- Partials      408      412       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit 1887d5c into main Oct 3, 2024
81 checks passed
@jjngx jjngx deleted the chore/refactor-manager-glog branch October 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code skip changelog Pull requests that don't need to be added to the changelog
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants