Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation style changes for the "Installation" section #6015

Merged
merged 25 commits into from
Jul 31, 2024

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jul 12, 2024

Proposed changes

This pull request is one of a series to update the documentation set to adhere to NGINX's contemporary documentation standards. The three most prominent changes are prepending F5 to the first instance of an NGINX product, changing titles to sentence case, and removing gerunds.

A number of pages also had their filenames changed to reflect their contents and to create shorter URL slugs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich ADubhlaoich self-assigned this Jul 12, 2024
@ADubhlaoich ADubhlaoich requested review from a team as code owners July 12, 2024 13:18
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 12, 2024
@ADubhlaoich ADubhlaoich requested a review from a team July 24, 2024 14:40
@vepatel vepatel enabled auto-merge (squash) July 25, 2024 18:11
@vepatel vepatel disabled auto-merge July 25, 2024 18:11
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6015/

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) July 30, 2024 15:09
@ADubhlaoich ADubhlaoich merged commit d3bdc77 into main Jul 31, 2024
48 checks passed
@ADubhlaoich ADubhlaoich deleted the f5-style-installation branch July 31, 2024 15:10
jjngx pushed a commit that referenced this pull request Aug 2, 2024
This commit is one of a series to update the documentation set to 
adhere to NGINX's contemporary documentation standards. 

The three most prominent changes are prepending F5 to the first instance 
of an NGINX product, changing titles to sentence case, and removing gerunds.

A number of pages also had their filenames changed to 
reflect their contents and to create shorter URL slugs.

---------

Signed-off-by: Alan Dooley <[email protected]>
Co-authored-by: Shaun <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
ADubhlaoich added a commit that referenced this pull request Aug 23, 2024
This commit is one of a series to update the documentation set to
adhere to NGINX's contemporary documentation standards.

The three most prominent changes are prepending F5 to the first instance
of an NGINX product, changing titles to sentence case, and removing gerunds.

A number of pages also had their filenames changed to
reflect their contents and to create shorter URL slugs.

---------

Signed-off-by: Alan Dooley <[email protected]>
Co-authored-by: Shaun <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants