Swift3 conversion #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
ra1028
reviewed
Oct 24, 2016
Example/Example/CustomCell.swift
Outdated
| @@ -18,10 +18,10 @@ class CustomCell: Cell, CellType { | |||
| return | |||
| } | |||
|
|
|||
| titleLabel.text = cellmodel.title + "(\(cellmodel.indexPath.section),\(cellmodel.indexPath.row))" | |||
| titleLabel.text = cellmodel.title + "(\((cellmodel.indexPath as NSIndexPath).section),\((cellmodel.indexPath as NSIndexPath).row))" | |||
| } | |||
There was a problem hiding this comment.
Unneeded casting
titleLabel.text = cellmodel.title + "(\(cellmodel.indexPath.section,\(cellmodel.indexPath.row))"
Hakuba/Hakuba.swift
Outdated
| subscript(indexPath: NSIndexPath) -> CellModel? { | ||
| return self[indexPath.section][indexPath.row] | ||
| subscript(indexPath: IndexPath) -> CellModel? { | ||
| return self[(indexPath as NSIndexPath).section][(indexPath as NSIndexPath).row] |
Hakuba/Hakuba.swift
Outdated
| public func getCellmodel(indexPath: NSIndexPath) -> CellModel? { | ||
| return sections.get(indexPath.section)?[indexPath.row] | ||
| public func getCellmodel(_ indexPath: IndexPath) -> CellModel? { | ||
| return sections.get((indexPath as NSIndexPath).section)?[(indexPath as NSIndexPath).row] | ||
| } |
Hakuba/Hakuba.swift
Outdated
| return remove(indexes: [index]) | ||
| } | ||
|
|
||
| func remove(range: Range<Int>) -> Self { | ||
| func remove(_ range: CountableClosedRange<Int>) -> Self { | ||
| let indexes = range.map { $0 } | ||
| return remove(indexes: indexes) | ||
| } |
There was a problem hiding this comment.
I think better if you add
func remove(_ range: CountableRange<Int>) -> Self {...}
| delegate?.scrollViewDidScroll?(scrollView) | ||
|
|
||
| if let indexPath = tableView?.indexPathsForVisibleRows?.first { | ||
| let topSection = indexPath.section | ||
| let topSection = (indexPath as NSIndexPath).section | ||
|
|
Hakuba/Hakuba.swift
Outdated
| .filter { $0 >= 0 && $0 < self.sectionsCount } | ||
|
|
||
| var remainSections: [Section] = [] | ||
| var i = 0 | ||
|
|
||
| for j in 0..<sectionsCount { | ||
| if let k = sortedIndexes.get(i) where k == j { | ||
| if let k = sortedIndexes.get(i) , k == j { |
There was a problem hiding this comment.
Remove a space previous to ,
Hakuba/Hakuba.swift
Outdated
| public func tableView(tableView: UITableView, willDisplayHeaderView view: UIView, forSection section: Int) { | ||
| guard let view = view as? HeaderFooterView where section == willFloatingSection else { | ||
| public func tableView(_ tableView: UITableView, willDisplayHeaderView view: UIView, forSection section: Int) { | ||
| guard let view = view as? HeaderFooterView , section == willFloatingSection else { |
There was a problem hiding this comment.
Remove a space previous to ,
Hakuba/Section.swift
Outdated
| .filter { $0 >= 0 && $0 < self.count } | ||
|
|
||
| var remainCellmodels: [CellModel] = [] | ||
| var i = 0 | ||
|
|
||
| for j in 0..<count { | ||
| if let k = sortedIndexes.get(i) where k == j { | ||
| if let k = sortedIndexes.get(i) , k == j { |
There was a problem hiding this comment.
Remove a space previous to ,
Hakuba/Section.swift
Outdated
| func remove(range: Range<Int>) -> Self { | ||
| let indexes = range.map { $0 } | ||
| func remove(_ range: CountableClosedRange<Int>) -> Self { | ||
| let indexes = [Int](range) |
There was a problem hiding this comment.
I think better if you add
func remove(_ range: CountableRange<Int>) -> Self {...}
|
I think you should add |
|
@ra1028 I updated the project according to your notes. Thanks for the review. |
|
@eskizyen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the code to Swift 3.0, example project runs without any problem.