Add option to use smartctl instead of hdparm -C, -I. Skip idle check if all drives are already sleeping. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add option to use smartctl instead of hdparm -C, hdparm -I (As hdparm -C and/or hdparm -I may wake up drive) - during main routine, Before checking if drives are idle, check if all drive is in standby mode. and if all drives are standby mode, skeep idle mode check and just sleep for TIMEOUT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hdparm -C and/or hdparm -I may wake up some drive, so added option (-r) to use smartctl instaead of hdparm(Afaik smartctl -i does not wake up drive).
During main loop, all_drive_idle check looks not really worthy if all drives are sleeping already. So Added check if all drive_is_sleeping before all drive_is idle check.