-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xml error logging #754
Merged
Merged
Xml error logging #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-beauchamp
force-pushed
the
xml-error-logging
branch
5 times, most recently
from
October 3, 2024 17:39
c7a5db2
to
ccdbe89
Compare
adam-beauchamp
force-pushed
the
xml-error-logging
branch
from
October 3, 2024 17:46
ccdbe89
to
f6cd64c
Compare
adam-beauchamp
force-pushed
the
xml-error-logging
branch
from
October 3, 2024 19:05
f6cd64c
to
10b1fc6
Compare
adam-beauchamp
force-pushed
the
xml-error-logging
branch
from
October 3, 2024 19:10
10b1fc6
to
f6b8d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize xml schema validation performance
Previous brute-force validation logic had poor performance on non-validating xml documents.
Updated validation logic to:
Added test cases for all schema version in
test_valid_sixsicd.cpp
test_valid_sixsidd.cpp
The jupyter notebook included in the request documents the verification strategy.