Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml error logging #754

Merged
merged 50 commits into from
Oct 4, 2024
Merged

Xml error logging #754

merged 50 commits into from
Oct 4, 2024

Conversation

adam-beauchamp
Copy link
Collaborator

@adam-beauchamp adam-beauchamp commented Sep 30, 2024

Optimize xml schema validation performance

Previous brute-force validation logic had poor performance on non-validating xml documents.

Updated validation logic to:

  • use simple string matching to guess the applicable schema for a document
  • perform validation once

Added test cases for all schema version in

  • test_valid_sixsicd.cpp
  • test_valid_sixsidd.cpp

The jupyter notebook included in the request documents the verification strategy.

@adam-beauchamp adam-beauchamp force-pushed the xml-error-logging branch 5 times, most recently from c7a5db2 to ccdbe89 Compare October 3, 2024 17:39
@adam-beauchamp adam-beauchamp merged commit 200dccc into main Oct 4, 2024
5 checks passed
@adam-beauchamp adam-beauchamp deleted the xml-error-logging branch October 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant