-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable TREElement.to_dict() to handle floating-point values (integration) #568
Merged
pressler-vsc
merged 4 commits into
ngageoint:integration/1.3.60
from
pressler-vsc:fix/tre-to_dict
Oct 30, 2024
Merged
enable TREElement.to_dict() to handle floating-point values (integration) #568
pressler-vsc
merged 4 commits into
ngageoint:integration/1.3.60
from
pressler-vsc:fix/tre-to_dict
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstob
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed tests pass
$ nox
nox > Running session test(version='3.6')
nox > Creating conda env in .nox/test-version-3-6 with python
nox > conda install --yes --prefix /home/vscuser/repos/nga_sarpy/.nox/test-version-3-6 python=3.6
nox > python -m pip install '.[all]'
nox > pytest tests
======================================================================================================= test session starts ========================================================================================================
platform linux -- Python 3.6.13, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/vscuser/repos/nga_sarpy
collected 802 items
tests/test_class_string.py . [ 0%]
tests/consistency/test_consistency.py ........ [ 1%]
tests/consistency/test_cphd_consistency.py .............................................................. [ 8%]
tests/consistency/test_sicd_consistency.py ... [ 9%]
tests/consistency/test_sidd_consistency.py ..... [ 9%]
tests/geometry/test_geocoords.py .......... [ 11%]
tests/geometry/test_geometry_elements.py .......... [ 12%]
tests/geometry/test_latlon.py ... [ 12%]
tests/geometry/test_point_projection.py .............. [ 14%]
tests/io/test_kml.py . [ 14%]
tests/io/DEM/test_dted.py .s [ 14%]
tests/io/DEM/test_geoid.py . [ 14%]
tests/io/DEM/test_geotiff1deg_list.py .... [ 15%]
tests/io/DEM/test_geotiff1deg_reader.py ........ [ 16%]
tests/io/complex/test_other_nitf.py ... [ 16%]
tests/io/complex/test_reader.py .ssssssssss [ 18%]
tests/io/complex/test_remote.py s [ 18%]
tests/io/complex/test_sicd.py . [ 18%]
tests/io/complex/test_sio.py . [ 18%]
tests/io/complex/test_utils.py . [ 18%]
tests/io/complex/sicd_elements/test_sicd_elements_antenna.py ... [ 19%]
tests/io/complex/sicd_elements/test_sicd_elements_base.py ... [ 19%]
tests/io/complex/sicd_elements/test_sicd_elements_blocks.py ..................... [ 22%]
tests/io/complex/sicd_elements/test_sicd_elements_collectioninfo.py .. [ 22%]
tests/io/complex/sicd_elements/test_sicd_elements_errorstatistics.py . [ 22%]
tests/io/complex/sicd_elements/test_sicd_elements_geodata.py ... [ 22%]
tests/io/complex/sicd_elements/test_sicd_elements_grid.py .. [ 23%]
tests/io/complex/sicd_elements/test_sicd_elements_imagecreation.py . [ 23%]
tests/io/complex/sicd_elements/test_sicd_elements_imagedata.py . [ 23%]
tests/io/complex/sicd_elements/test_sicd_elements_imageformation.py ...... [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_matchinfo.py . [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_pfa.py . [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_position.py ... [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_radarcollection.py .............. [ 26%]
tests/io/complex/sicd_elements/test_sicd_elements_radiometric.py . [ 26%]
tests/io/complex/sicd_elements/test_sicd_elements_rgazcomp.py . [ 26%]
tests/io/complex/sicd_elements/test_sicd_elements_rma.py ... [ 27%]
tests/io/complex/sicd_elements/test_sicd_elements_scpcoa.py ................... [ 29%]
tests/io/complex/sicd_elements/test_sicd_elements_sicd.py ................................... [ 33%]
tests/io/complex/sicd_elements/test_sicd_elements_timeline.py .................. [ 36%]
tests/io/complex/sicd_elements/test_sicd_elements_utils.py ... [ 36%]
tests/io/general/test_base.py ... [ 36%]
tests/io/general/test_data_segment.py .......... [ 38%]
tests/io/general/test_format_function.py ........ [ 39%]
tests/io/general/test_nitf.py .. [ 39%]
tests/io/general/test_nitf_headers.py . [ 39%]
tests/io/general/test_nitf_image.py .... [ 39%]
tests/io/general/test_tre.py ... [ 40%]
tests/io/phase_history/test_cphd.py ....... [ 41%]
tests/io/phase_history/test_cphd_versions.py ..... [ 41%]
tests/io/phase_history/cphd1_elements/test_cphd.py ...... [ 42%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_antenna.py ..... [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_blocks.py .... [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_channel.py . [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_data.py . [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_dwell.py . [ 44%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_geoinfo.py ... [ 44%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_global.py .. [ 44%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_pvp.py . [ 44%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_referencegeometry.py . [ 44%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_supportarray.py .. [ 45%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_txrcv.py . [ 45%]
tests/io/phase_history/cphd1_elements/test_utils.py . [ 45%]
tests/io/product/test_reader.py ...s [ 45%]
tests/io/product/test_sidd.py .............. [ 47%]
tests/io/product/test_sidd_schema.py ......... [ 48%]
tests/io/product/test_sidd_writing.py ... [ 49%]
tests/io/product/sidd1_elements/test_exploitationfeatures.py ......................................................... [ 56%]
tests/io/product/sidd2_elements/test_exploitationfeatures.py .................................................................... [ 64%]
tests/io/product/sidd3_elements/test_exploitationfeatures.py ............................................................................................................................................................... [ 84%]
...................................................................... [ 93%]
tests/io/product/sidd3_elements/test_sidd3_elements.py ..... [ 93%]
tests/io/received/test_crsd.py . [ 94%]
tests/processing/sicd/test_spectral_taper.py ........ss........... [ 96%]
tests/utils/test_sicd_sidelobe_control.py .. [ 96%]
tests/visualization/test_cphd_kmz_product_creation.py .. [ 97%]
tests/visualization/test_crsd_kmz_product_creation.py . [ 97%]
tests/visualization/test_kmz_product_creation.py .x [ 97%]
tests/visualization/test_remap.py .................... [100%]
========================================================================================================= warnings summary =========================================================================================================
tests/geometry/test_point_projection.py::test_image_to_ground_errors
tests/geometry/test_point_projection.py::test_image_to_ground_dem
/home/vscuser/repos/nga_sarpy/sarpy/geometry/point_projection.py:1882: RuntimeWarning: divide by zero encountered in double_scalars
lon_grid_size = min(10, lat_grid_size/abs(numpy.sin(numpy.deg2rad(ref_llh[0]))))
tests/visualization/test_kmz_product_creation.py::test_create_kmz[True]
/home/vscuser/repos/nga_sarpy/sarpy/visualization/kmz_utils.py:169: RuntimeWarning: invalid value encountered in double_scalars
+ dir_z**2 * semiaxis_a**2 * semiaxis_b**2
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
===================================================================================== 786 passed, 15 skipped, 1 xfailed, 3 warnings in 42.30s ======================================================================================
nox > Session test(version='3.6') was successful.
nox > Running session test(version='3.11')
nox > Creating conda env in .nox/test-version-3-11 with python
nox > conda install --yes --prefix /home/vscuser/repos/nga_sarpy/.nox/test-version-3-11 python=3.11
nox > python -m pip install '.[all]'
nox > pytest tests
======================================================================================================= test session starts ========================================================================================================
platform linux -- Python 3.11.10, pytest-8.3.3, pluggy-1.5.0
rootdir: /home/vscuser/repos/nga_sarpy
collected 802 items
tests/consistency/test_consistency.py ........ [ 0%]
tests/consistency/test_cphd_consistency.py .............................................................. [ 8%]
tests/consistency/test_sicd_consistency.py ... [ 9%]
tests/consistency/test_sidd_consistency.py ..... [ 9%]
tests/geometry/test_geocoords.py .......... [ 10%]
tests/geometry/test_geometry_elements.py .......... [ 12%]
tests/geometry/test_latlon.py ... [ 12%]
tests/geometry/test_point_projection.py .............. [ 14%]
tests/io/DEM/test_dted.py .s [ 14%]
tests/io/DEM/test_geoid.py . [ 14%]
tests/io/DEM/test_geotiff1deg_list.py .... [ 15%]
tests/io/DEM/test_geotiff1deg_reader.py ........ [ 16%]
tests/io/complex/sicd_elements/test_sicd_elements_antenna.py ... [ 16%]
tests/io/complex/sicd_elements/test_sicd_elements_base.py ... [ 16%]
tests/io/complex/sicd_elements/test_sicd_elements_blocks.py ..................... [ 19%]
tests/io/complex/sicd_elements/test_sicd_elements_collectioninfo.py .. [ 19%]
tests/io/complex/sicd_elements/test_sicd_elements_errorstatistics.py . [ 19%]
tests/io/complex/sicd_elements/test_sicd_elements_geodata.py ... [ 20%]
tests/io/complex/sicd_elements/test_sicd_elements_grid.py .. [ 20%]
tests/io/complex/sicd_elements/test_sicd_elements_imagecreation.py . [ 20%]
tests/io/complex/sicd_elements/test_sicd_elements_imagedata.py . [ 20%]
tests/io/complex/sicd_elements/test_sicd_elements_imageformation.py ...... [ 21%]
tests/io/complex/sicd_elements/test_sicd_elements_matchinfo.py . [ 21%]
tests/io/complex/sicd_elements/test_sicd_elements_pfa.py . [ 21%]
tests/io/complex/sicd_elements/test_sicd_elements_position.py ... [ 22%]
tests/io/complex/sicd_elements/test_sicd_elements_radarcollection.py .............. [ 23%]
tests/io/complex/sicd_elements/test_sicd_elements_radiometric.py . [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_rgazcomp.py . [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_rma.py ... [ 24%]
tests/io/complex/sicd_elements/test_sicd_elements_scpcoa.py ................... [ 26%]
tests/io/complex/sicd_elements/test_sicd_elements_sicd.py ................................... [ 31%]
tests/io/complex/sicd_elements/test_sicd_elements_timeline.py .................. [ 33%]
tests/io/complex/sicd_elements/test_sicd_elements_utils.py ... [ 33%]
tests/io/complex/test_other_nitf.py ... [ 34%]
tests/io/complex/test_reader.py .ssssssssss [ 35%]
tests/io/complex/test_remote.py s [ 35%]
tests/io/complex/test_sicd.py . [ 35%]
tests/io/complex/test_sio.py . [ 36%]
tests/io/complex/test_utils.py . [ 36%]
tests/io/general/test_base.py ... [ 36%]
tests/io/general/test_data_segment.py .......... [ 37%]
tests/io/general/test_format_function.py ........ [ 38%]
tests/io/general/test_nitf.py .. [ 39%]
tests/io/general/test_nitf_headers.py . [ 39%]
tests/io/general/test_nitf_image.py .... [ 39%]
tests/io/general/test_tre.py ... [ 40%]
tests/io/phase_history/cphd1_elements/test_cphd.py ...... [ 40%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_antenna.py ..... [ 41%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_blocks.py .... [ 41%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_channel.py . [ 42%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_data.py . [ 42%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_dwell.py . [ 42%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_geoinfo.py ... [ 42%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_global.py .. [ 42%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_pvp.py . [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_referencegeometry.py . [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_supportarray.py .. [ 43%]
tests/io/phase_history/cphd1_elements/test_cphd1_elements_txrcv.py . [ 43%]
tests/io/phase_history/cphd1_elements/test_utils.py . [ 43%]
tests/io/phase_history/test_cphd.py ....... [ 44%]
tests/io/phase_history/test_cphd_versions.py ..... [ 45%]
tests/io/product/sidd1_elements/test_exploitationfeatures.py ......................................................... [ 52%]
tests/io/product/sidd2_elements/test_exploitationfeatures.py .................................................................... [ 60%]
tests/io/product/sidd3_elements/test_exploitationfeatures.py ............................................................................................................................................................... [ 80%]
...................................................................... [ 89%]
tests/io/product/sidd3_elements/test_sidd3_elements.py ..... [ 89%]
tests/io/product/test_reader.py ...s [ 90%]
tests/io/product/test_sidd.py .............. [ 92%]
tests/io/product/test_sidd_schema.py ......... [ 93%]
tests/io/product/test_sidd_writing.py ... [ 93%]
tests/io/received/test_crsd.py . [ 93%]
tests/io/test_kml.py . [ 93%]
tests/processing/sicd/test_spectral_taper.py ..................... [ 96%]
tests/test_class_string.py . [ 96%]
tests/utils/test_sicd_sidelobe_control.py .. [ 96%]
tests/visualization/test_cphd_kmz_product_creation.py .. [ 97%]
tests/visualization/test_crsd_kmz_product_creation.py . [ 97%]
tests/visualization/test_kmz_product_creation.py .x [ 97%]
tests/visualization/test_remap.py .................... [100%]
========================================================================================================= warnings summary =========================================================================================================
tests/geometry/test_geometry_elements.py: 77 warnings
/home/vscuser/repos/nga_sarpy/sarpy/geometry/geometry_elements.py:131: DeprecationWarning: Arrays of 2-dimensional vectors are deprecated. Use arrays of 3-dimensional vectors instead. (deprecated in NumPy 2.0)
dir_cross = float(numpy.cross(R, S)) # the scalar cross product of the direction vectors
tests/geometry/test_geometry_elements.py: 43 warnings
/home/vscuser/repos/nga_sarpy/sarpy/geometry/geometry_elements.py:137: DeprecationWarning: Arrays of 2-dimensional vectors are deprecated. Use arrays of 3-dimensional vectors instead. (deprecated in NumPy 2.0)
end_cross_0 = float(numpy.cross(Q-P, S))
tests/geometry/test_geometry_elements.py: 43 warnings
/home/vscuser/repos/nga_sarpy/sarpy/geometry/geometry_elements.py:138: DeprecationWarning: Arrays of 2-dimensional vectors are deprecated. Use arrays of 3-dimensional vectors instead. (deprecated in NumPy 2.0)
end_cross_1 = float(numpy.cross(Q-P, R))
tests/geometry/test_point_projection.py::test_image_to_ground_errors
tests/geometry/test_point_projection.py::test_image_to_ground_dem
/home/vscuser/repos/nga_sarpy/sarpy/geometry/point_projection.py:1882: RuntimeWarning: divide by zero encountered in scalar divide
lon_grid_size = min(10, lat_grid_size/abs(numpy.sin(numpy.deg2rad(ref_llh[0]))))
tests/test_class_string.py::TestClassString::test_class_str
/home/vscuser/repos/nga_sarpy/sarpy/annotation/afrl_rde_schema/__init__.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
import pkg_resources
tests/visualization/test_kmz_product_creation.py::test_create_kmz[True]
/home/vscuser/repos/nga_sarpy/sarpy/visualization/kmz_utils.py:145: RuntimeWarning: invalid value encountered in scalar divide
distance = (
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
==================================================================================== 788 passed, 13 skipped, 1 xfailed, 167 warnings in 30.89s =====================================================================================
nox > Session test(version='3.11') was successful.
nox > Ran multiple sessions:
nox > * test(version='3.6'): success
nox > * test(version='3.11'): success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Credit to @bndkr. This PR builds atop #566:
integration/1.3.60
Test Results
tests pass