Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR is for removing Magical Record #115

Draft
wants to merge 65 commits into
base: develop
Choose a base branch
from
Draft

This PR is for removing Magical Record #115

wants to merge 65 commits into from

Conversation

danielbarela
Copy link
Member

No description provided.

@danielbarela danielbarela changed the title Updating tests and deleting unused code - WIP Updating tests and deleting unused code Aug 22, 2024
@danielbarela
memory leak fixes, test fixes
14f3220
@danielbarela
BottomSheetRepository tests
625facd
@danielbarela
mock the repositories and use those in the bottom sheet repository tests
b465361
@danielbarela
UserRepository tests
6948dda
@danielbarela
move geopackage initialization to geopackage repository
f11a645
@danielbarela
LocationRepository tests
7e35e6e
@danielbarela
user local data source tests
69603a9
@danielbarela
move uri publisher to the core data data source
8eaf2a5 
location data source tests
@danielbarela
context is now injected
a5a43a1
@danielbarela
observation local data source tests
4ff98c7
@danielbarela
MAGEFormFetched sends event model
31816e1 
observation repository tests
@danielbarela
ObservationImageRepository
e227c9d 
ObservationViewViewModel tests
ObservationModel tests
reorganizing view models and models to the appropriate folders
@danielbarela
reorganizing files
f74fb96
@danielbarela
test updates
3be1a29
@danielbarela
clean up some test memory leaks
8322a3b
@danielbarela
move fetchMyself to user repository
b012097
@danielbarela
user remote and user repository fetch myself tests
20914ac
@danielbarela
update tests to use proper class for retrieving resources
d2b2c7c
@danielbarela
update test classes to pass context
9c9d26c
@danielbarela
event repository tests
2ad61b7
@danielbarela
initial move from mr_ methods to context methods
442cadd
@danielbarela
project file
1cd6b86
@danielbarela
more removal of magical record and adding back in tests
fb56963
@danielbarela
geopackage base map tests, geometry edit controller tests
380fc7b
@danielbarela
Update Straight line nav tests
4646fc5
@danielbarela
expandable card tests updates
fdf3ed9
@danielbarela
form picker tests updated
bdc8ef0
@danielbarela
update observation form reorder tests
1c786c1
@danielbarela
common field tests updates
98ebf2f
@danielbarela
geometry edit view controller tests updates
511d3ed
@danielbarela
edit controller test updates
526e422
@danielbarela
edit coordinator test updates
a2b5ac5
@danielbarela
update observation form view tests
b00d0f4
@danielbarela
fixing case where attachment cell is recycled before the image loads
cb8dedf 
attachment field view tests
@danielbarela
update checkbox field view tests
d1b31bc
@danielbarela
update date view tests
18a4f07
@danielbarela
update dropdown field view tests
2f849b6
@danielbarela
update geometry view tests
2d4342b
@danielbarela
update number field tests
71b7966
@danielbarela
update radio field tests
25c1b95
@danielbarela
update text view tests
955dddd
@danielbarela
removal of unused classes
5ea4400
@danielbarela
event chooser coordinator test fixes
8e71687
@danielbarela
move geopackage tests to their own test target
5088c5f
@danielbarela
observation push service magical record removal
95bc698
@danielbarela
attachment push service -> Swift
c07ebe5
@danielbarela
device uuid -> Swift
0917fb8
@danielbarela
delete header file
7be7e5c
@danielbarela
remove references to deleted file
36874db
@danielbarela
fixed misspelling
5bd477f
@danielbarela danielbarela changed the title Updating tests and deleting unused code This PR is for removing Magical Record Nov 13, 2024
@danielbarela
Copy link
Member Author

This branch and PR have the following changes from develop

  • Magical Record removal; This is incomplete and needs to be tested thoroughly
  • Initial SwiftUI updates to some views
  • Initial repository and data source updates
  • lots of tests

@danielbarela
Copy link
Member Author

Recommended path forward:

  1. finish removing magical record
  2. thoroughly test
  3. merge this and then create new PRs for moving all obj-c code to swift
  4. thoroughly test and merge
  5. Remove AFNetworking in favor of Alamofire which would include creating URLRequestConvertible enums
  6. Create all repositories and local and remote data sources
  7. SwiftUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielbarela