Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fill rule #139

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

ramirezcgn
Copy link
Contributor

Fixes #62

Code quality

  • I made some tests for my changes
  • I added my name in the
    contributors
    field of the package.json file

License

To get your contribution merged, you must check the following.

  • I read the project license in the LICENSE file
  • I agree with publishing under this project license

Join

  • I wish to join the core team
  • I agree that with great powers comes responsibilities
  • I'm a nice person

My NPM username: ramirezcgn

@jebos
Copy link

jebos commented Jan 26, 2022

Good work! I can confirm that those changes are fixing the issue for me. 100% success.

@eyr1n eyr1n mentioned this pull request Mar 8, 2022
@nfroidure
Copy link
Owner

Looking at the code, it looks like the paper dependency is making the script slower since it brokes the tests timeouts. I'd like to have advice from the users community whether it worth the merge knowing that one can transforms its SVG files with Inkscape to avoid having fill-rule in them. LMKWYT.

Ramirez Nicolás and others added 2 commits July 26, 2022 17:44
@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 58.833% when pulling f131f70 on ramirezcgn:support-fill-rule into 7bafaf3 on nfroidure:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seems that fill-rule="evenodd" does not works correctly
4 participants