add pff to update workflow

.github/workflows/update_players.yaml

@@ -49,15 +49,15 @@ jobs:
  echo "seasons=$seasons" >> "$GITHUB_OUTPUT"
 
 
- update_roster_and_draft:
+ update_season_data:
  needs: update_setup
  name: Update ${{ matrix.season }} ${{ matrix.type }} data
  runs-on: ubuntu-latest
  strategy:
  fail-fast: false
  matrix:
  season: ${{ fromJson(needs.update_setup.outputs.seasons) }}
- type: ["roster", "raw_draft"]
+ type: ["roster", "raw_draft", "raw_pff"]
  env:
  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  GITHUB_PAT: ${{ secrets.NFLVERSE_GH_TOKEN }}
@@ -74,16 +74,16 @@ jobs:
  with:
  extra-packages: local::.
  - name: Release ${{ matrix.season }} ${{ matrix.type }}
- run: Rscript -e 'source("build/00_update_roster_and_draft.R")'
+ run: Rscript -e 'source("build/00_update_season_data.R")'
 
  update_components:
- needs: [update_setup, update_roster_and_draft]
+ needs: [update_setup, update_season_data]
  name: Update ${{ matrix.type }} data
  runs-on: ubuntu-latest
  strategy:
  fail-fast: false
  matrix:
- type: ["basis", "pfr", "otc", "draft"]
+ type: ["basis", "pfr", "otc", "pff", "draft"]
  env:
  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  GITHUB_PAT: ${{ secrets.NFLVERSE_GH_TOKEN }}

NAMESPACE

@@ -2,13 +2,15 @@
 
 export(.basis_release_raw_roster)
 export(.draft_release_season)
+export(.pff_release_raw_players)
 export(players_basis_release)
 export(players_build_dataset)
 export(players_download)
 export(players_draft_release)
 export(players_fetch_manual_ids)
 export(players_manual_overwrite)
 export(players_otc_release)
+export(players_pff_release)
 export(players_pfr_release)
 export(players_validate)
 export(players_validate_extract_replicated)

R/players_build_dataset.R

@@ -23,8 +23,8 @@ players_build_dataset <- function(release = FALSE){
  pfr <- players_download("pfr") |>
  remove_replicated("pfr_id")
 
- # at the moment, we take pff ids from the otc dataset
- # pff <- players_download("pff")
+ pff <- players_download("pff") |>
+  remove_replicated("pff_id")
 
  otc <- players_download("otc") |>
  dplyr::mutate(dplyr::across(c(otc_id, pff_id), as.integer)) |>
@@ -51,6 +51,10 @@ players_build_dataset <- function(release = FALSE){
  otc |> dplyr::select(gsis_id, pff_id, otc_id),
  by = "gsis_id"
  ) |>
+ dplyr::left_join(
+ pff |> dplyr::select(pff_id, pff_position, pff_status),
+ by = "pff_id"
+ ) |>
  dplyr::left_join(
  draft, by = "pfr_id"
  ) |>

build/00_update_roster_and_draft.R → build/00_update_season_data.R

@@ -1,7 +1,7 @@
 season <- Sys.getenv("NFLVERSE_UPDATE_SEASON", unset = NA_character_) |> as.integer()
 
 type <- Sys.getenv("NFLVERSE_UPDATE_TYPE", unset = NA_character_)
-type <- rlang::arg_match0(type, c("roster", "raw_draft"))
+type <- rlang::arg_match0(type, c("roster", "raw_draft", "raw_pff"))
 
 if (type == "roster"){
  out <- nflverse.players::.basis_release_raw_roster(seasons = season)
@@ -12,4 +12,6 @@ if (type == "roster"){
  if (Sys.Date() %in% nflverse.players:::.draft_date_range()){
  out <- nflverse.players::.draft_release_season(years = season)
  }
+} else if (type == "raw_pff" && .pff_is_valid_season(season)){
+ out <- nflverse.players::.pff_release_raw_players(seasons = season)
 }

build/01_update_components.R

@@ -1,5 +1,5 @@
 type <- Sys.getenv("NFLVERSE_UPDATE_TYPE", unset = NA_character_)
-type <- rlang::arg_match0(type, c("basis", "pfr", "otc", "draft"))
+type <- rlang::arg_match0(type, c("basis", "pfr", "otc", "draft", "pff"))
 
 if (type == "basis"){
  out <- nflverse.players::players_basis_release()
@@ -11,4 +11,6 @@ if (type == "basis"){
  out <- nflverse.players::players_otc_release()
 } else if (type == "draft"){
  out <- nflverse.players::players_draft_release()
+} else if (type == "pff"){
+ out <- nflverse.players::players_pff_release()
 }