-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing ontology examples in Isa specification #115
Comments
Hey @UrsulaE, thanks for your feedback. Explanations to your points
Yes, for referencing a given Ontology term, we use two distinct notations:
As the URL for the value, both annotations can be used. In the header, only the short annotation is allowed. The text only refers to the headers, which is probably what caused the confusion.
The URIs and short-annotations are basically interchangeable in the datamodel and parsing. Swate-Alpha only showing the Short accession is just a matter of display. E.g. this table in swate-alpha will look like this when downloaded: Possible SolutionMaybe I could add some explanations about the range of the values (as opposed to the columns) and make a distinction there? Let me know if this would help clear up the confusing elements in the specs. |
Thanks, Lucas, for your replies. Ursula
From: Lukas Weil ***@***.***>
Sent: Monday, August 5, 2024 2:57 PM
To: nfdi4plants/ARC-specification ***@***.***>
Cc: Ursula Eberhardt ***@***.***>; Mention ***@***.***>
Subject: Re: [nfdi4plants/ARC-specification] Confusing ontology examples in Isa specification (Issue #115)
Hey @UrsulaE<https://github.com/UrsulaE>,
thanks for your feedback.
Explanations to your points
a. I realize that there may not be any real disagreement, only different notations.
Yes, for referencing a given ontology Ontology terms, we use two distinct notations:
1. URI notation: Full URL linking to the Annotation term
e.g. http://purl.obolibrary.org/obo/OBI_0003114
2. Short accession: <IDSPACE>:<LOCALID>
e.g. OBI:0003114
As the URL for the value, both annotation can be used. In the header, only the short annotation is allowed. The text only refers to the headers, which is probably what caused the confusion.
b. The URIs in the examples include links. Tools like swate-alpha only allow the insertion of simple text, not links.
The URIs and short-annotations are basically interchangeable in the datamodel and parsing. Swate-Alpha only showing the Short accession is just a matter of display.
E.g. this table in swate-alpha
image.png (view on web)<https://github.com/user-attachments/assets/6cf9e985-c9e8-4bc0-a233-231653afa06b>
will look like this when downloaded:
image.png (view on web)<https://github.com/user-attachments/assets/8899eb1d-c7e2-4190-967c-fcec3612f65f>
Possible Solution
Maybe I could add some explanations about the range of the values (as opposed to the columns) and make a distinction there? Let me know if this would help clear up the confusing elements in the specs.
—
Reply to this email directly, view it on GitHub<#115 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB7MQBUHWW4ZCE3OFD7P35LZP5ZCJAVCNFSM6AAAAABL4NATM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGAYTGNBXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@UrsulaE, I closed this issue as the PR containing the changes was merged. I hope the incorporated explanations answer your confusion. If not, feel free to reopen! |
The instructions of how to refer to ontology terms (https://github.com/nfdi4plants/ARC-specification/blob/main/ISA-XLSX.md#ontology-annotations) seem to disagree between the description text, use "<IDSPACE>:<LOCALID>", and the examples in which in the first example (NCBITaxon) the respective obo link http://... is given, in a later example (Liver) the source ontology (Mesh) omitted with the term id (D008099).
a. I realize that there may not be any real disagreement, only different notations.
b. The URIs in the examples include links. Tools like swate-alpha only allow the insertion of simple text, not links.
Looks like these examples come directly from https://isa-specs.readthedocs.io/en/latest/isatab.html#ontology-annotations, which may explain the differences. Given that this is a reference text for users from different realms, I feel it would be better to resolve the disagreement (even if it was not real) by giving more explanations or by adjusting the examples to the text.
The text was updated successfully, but these errors were encountered: