Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing ontology examples in Isa specification #115

Closed
UrsulaE opened this issue Aug 2, 2024 · 3 comments
Closed

Confusing ontology examples in Isa specification #115

UrsulaE opened this issue Aug 2, 2024 · 3 comments
Assignees

Comments

@UrsulaE
Copy link

UrsulaE commented Aug 2, 2024

The instructions of how to refer to ontology terms (https://github.com/nfdi4plants/ARC-specification/blob/main/ISA-XLSX.md#ontology-annotations) seem to disagree between the description text, use "<IDSPACE>:<LOCALID>", and the examples in which in the first example (NCBITaxon) the respective obo link http://... is given, in a later example (Liver) the source ontology (Mesh) omitted with the term id (D008099).

a. I realize that there may not be any real disagreement, only different notations.
b. The URIs in the examples include links. Tools like swate-alpha only allow the insertion of simple text, not links.

Looks like these examples come directly from https://isa-specs.readthedocs.io/en/latest/isatab.html#ontology-annotations, which may explain the differences. Given that this is a reference text for users from different realms, I feel it would be better to resolve the disagreement (even if it was not real) by giving more explanations or by adjusting the examples to the text.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Aug 2, 2024
@HLWeil HLWeil removed the Status: Needs Triage This item is up for investigation. label Aug 5, 2024
@HLWeil HLWeil moved this to In discussion in ARCStack Aug 5, 2024
@HLWeil
Copy link
Member

HLWeil commented Aug 5, 2024

Hey @UrsulaE,

thanks for your feedback.

Explanations to your points

a. I realize that there may not be any real disagreement, only different notations.

Yes, for referencing a given Ontology term, we use two distinct notations:

  1. URI notation: Full URL linking to the Annotation term
    e.g. http://purl.obolibrary.org/obo/OBI_0003114

  2. Short accession: <IDSPACE>:<LOCALID>
    e.g. OBI:0003114

As the URL for the value, both annotations can be used. In the header, only the short annotation is allowed. The text only refers to the headers, which is probably what caused the confusion.

b. The URIs in the examples include links. Tools like swate-alpha only allow the insertion of simple text, not links.

The URIs and short-annotations are basically interchangeable in the datamodel and parsing. Swate-Alpha only showing the Short accession is just a matter of display.

E.g. this table in swate-alpha

image

will look like this when downloaded:

image

Possible Solution

Maybe I could add some explanations about the range of the values (as opposed to the columns) and make a distinction there? Let me know if this would help clear up the confusing elements in the specs.

@UrsulaE
Copy link
Author

UrsulaE commented Aug 26, 2024 via email

@HLWeil HLWeil self-assigned this Sep 6, 2024
@HLWeil HLWeil closed this as completed Sep 11, 2024
@github-project-automation github-project-automation bot moved this from In discussion to Done in ARCStack Sep 11, 2024
@HLWeil
Copy link
Member

HLWeil commented Sep 11, 2024

@UrsulaE, I closed this issue as the PR containing the changes was merged.

I hope the incorporated explanations answer your confusion. If not, feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants