Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nextflow_schema.json #1397

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update nextflow_schema.json #1397

wants to merge 1 commit into from

Conversation

rraadd88
Copy link

@rraadd88 rraadd88 commented Oct 2, 2024

This is a suggestion to clarify the description of the --skip_qc argument. Based on my understanding of the workflow, this argument applies to the stage 4 (post-processing) and 5 (final QC) including DeSeq based QC. I hope this is correct.

Clarification of which QCs are skipped is necessary because steps in stage could also be considered as QC steps. Perhaps a list of skipped QCs would be helpful. For example, I am not sure if --skip_qc skips RSeQC or not.

I hope the documentation for this argument could be more informative.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Oct 2, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @rraadd88,

It looks like this pull-request is has been made against the rraadd88/rnaseq-1 master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the rraadd88/rnaseq-1 dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@rraadd88 rraadd88 changed the base branch from master to dev October 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant