Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v3.0.2 #82

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

nf-core-bot
Copy link
Member

Version 3.0.2 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-3.0.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v3.0.2 release page.

@nschcolnicov nschcolnicov self-requested a review November 14, 2024 19:54
@nschcolnicov nschcolnicov self-requested a review November 14, 2024 19:56
Copy link

github-actions bot commented Nov 14, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f953acd

+| ✅ 199 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-14 20:08:06

@nschcolnicov
Copy link

@atrigila Since we won't have nf-tests until we merge #95, but we need to merge the template so the CI tests can pass, I just verified the proper execution of the test profiles: test, test_full, test_samples and test_scores.
We should use the nf-tests generated from your branch, and then you can manually add the nf-tests to this branch and run them, to verify that they are still producing the same outputs after updating the template

Copy link

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your plan, merge this PR and then pipeline-level tests.

@nschcolnicov nschcolnicov merged commit 6f9578e into dev Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants