Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization & address PR comments #51

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

christopher-mohr
Copy link
Collaborator

This

  • addresses the requested changes of the release PR Release 1.2.0 #49
  • makes the heatmap gene filter file a proper input channel
  • makes sure that the (non-default) normalization method is also used for the non-HK counts
  • adds housekeeping_norm = FALSE while loading counts for non-HK count table to make sure that no HK-normalization happens while loading the counts

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 84af8f5

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-01 06:44:36

@apeltzer apeltzer merged commit b193b16 into nf-core:dev Sep 1, 2023
6 checks passed
@christopher-mohr christopher-mohr deleted the address_PR_comments branch September 1, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants