Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template update 2.14.1 #290

Merged
merged 8 commits into from
May 23, 2024
Merged

Conversation

danilodileo
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/metatdenovo branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented May 17, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 01e2aaa

+| ✅ 215 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • system_exit - System.exit in NfcoreSchema.groovy: System.exit(1) [line 180]

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-22 14:19:48

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny question, otherwise fine. There are many failing tests and tests that didn't run though.

modules/local/transdecoder.nf Show resolved Hide resolved
@danilodileo danilodileo merged commit 72de31f into nf-core:dev May 23, 2024
8 checks passed
@danilodileo danilodileo deleted the template-update-2.14.1 branch September 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants