Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cellranges/mkfastq module #283

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Update cellranges/mkfastq module #283

merged 1 commit into from
Nov 4, 2024

Conversation

alanmmobbs93
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • CHANGELOG.md is updated.

Changed

  • Update module cellranges/mkfastq after ticket #281

@alanmmobbs93 alanmmobbs93 requested a review from a team as a code owner November 4, 2024 18:11
@alanmmobbs93 alanmmobbs93 requested review from matthdsm and removed request for a team November 4, 2024 18:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 175b85b

+| ✅ 203 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.5.2
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-04 18:59:35

@nschcolnicov nschcolnicov self-requested a review November 4, 2024 19:10
nschcolnicov
nschcolnicov approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nschcolnicov
Copy link
Contributor

Thank you very much @alanmmobbs93 for taking care of #281

@nschcolnicov nschcolnicov merged commit 6de9710 into nf-core:dev Nov 4, 2024
16 checks passed
@nschcolnicov nschcolnicov mentioned this pull request Nov 4, 2024
Closed
@alanmmobbs93 alanmmobbs93 deleted the update/mkfastq branch November 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschcolnicov nschcolnicov nschcolnicov approved these changes

@matthdsm matthdsm Awaiting requested review from matthdsm matthdsm is a code owner automatically assigned from nf-core/demultiplex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanmmobbs93 @nschcolnicov