Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update csv header in usage.md #194

Closed
wants to merge 2 commits into from
Closed

Update csv header in usage.md #194

wants to merge 2 commits into from

Conversation

grst
Copy link
Member

@grst grst commented Jul 1, 2024

The csv header and the description table didn't match and also didn't match the example samplesheet from nf-core/testdatasets

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Aratz and others added 2 commits February 27, 2024 16:30
@Aratz
Merge pull request #177 from nf-core/dev
aa4d936 
Release candidate 1.4.1
@grst
Update csv header in usage.md
f793854 
The csv header and the description table didn't match and also didn't match the example samplesheet from nf-core/testdatasets
@grst grst requested a review from a team as a code owner July 1, 2024 11:26
@grst grst requested review from kobelavaerts and removed request for a team July 1, 2024 11:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @grst,

It looks like this pull-request is has been made against the nf-core/demultiplex master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/demultiplex dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@matthdsm matthdsm changed the base branch from master to dev July 1, 2024 11:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f793854

+| ✅ 166 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.4.1
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in WorkflowDemultiplex.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-07-01 11:27:23

@grst
Copy link
Member Author

grst commented Jul 1, 2024

Turns out it was rather the description that's outdated. id and flowcell seems to be correct.

@grst grst closed this Jul 1, 2024
@apeltzer apeltzer deleted the grst-patch-1 branch August 12, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobelavaerts kobelavaerts Awaiting requested review from kobelavaerts kobelavaerts is a code owner automatically assigned from nf-core/demultiplex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grst @Aratz