Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sgalera #183

Closed
wants to merge 111 commits into from
Closed

Sgalera #183

wants to merge 111 commits into from

Conversation

sgaleraalq
Copy link

  • Fastq screen module added
  • Test dragen config now has correct inputs: sample size, subset for fastq_screen, kraken db, split by

@sgaleraalq sgaleraalq requested review from blajoie and a team as code owners March 27, 2024 13:38
@sgaleraalq sgaleraalq requested review from glichtenstein and removed request for a team March 27, 2024 13:38
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @sgaleraalq,

It looks like this pull-request is has been made against the Nasertic/nfcore_demultiplex master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the Nasertic/nfcore_demultiplex dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@sgaleraalq
Copy link
Author

Sorry, misclicked on our own fork

@sgaleraalq sgaleraalq closed this Mar 27, 2024
@edmundmiller
Copy link
Collaborator

All good! Any desire to contribute those upstream? 😆

I think those would be welcomed, see #36 and the HPC config could be split off into nf-core/configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants