Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hasta.config #703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update hasta.config #703

wants to merge 2 commits into from

Conversation

sofstam
Copy link
Contributor

@sofstam sofstam commented Jun 12, 2024 •
edited
Loading

This PR updates the hasta.config for taxprofiler

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

@sofstam sofstam marked this pull request as ready for review June 12, 2024 12:33
LilyAnderssonLee
LilyAnderssonLee reviewed Jun 12, 2024
View reviewed changes
conf/pipeline/taxprofiler/hasta.config
@@ -7,6 +7,18 @@ params {

process {

withName:'FASTQC' {
memory = { check_max( 4.GB * task.attempt, 'memory' ) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure 4GB is big enough? The default is 6. Should it be bigger than 6GB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyAnderssonLee LilyAnderssonLee LilyAnderssonLee left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofstam @LilyAnderssonLee