Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Remove aws tower profile #550

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP - Remove aws tower profile #550

wants to merge 3 commits into from

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Sep 15, 2023 •
edited by jfy133
Loading

Need to deal with demultiplex

Will close #550

name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any
  • Requested review from @nf-core/maintainers and/or #request-review on slack

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

@jfy133 jfy133 marked this pull request as ready for review May 15, 2024 18:13
@jfy133 jfy133 requested a review from ggabernet as a code owner May 15, 2024 18:13
@jfy133 jfy133 marked this pull request as draft May 15, 2024 18:13
@jfy133
Copy link
Member

jfy133 commented May 15, 2024

@maxulysse is this still relevant?

@jfy133 jfy133 linked an issue May 15, 2024 that may be closed by this pull request
Is aws_tower config superfluous? #483
Open
@maxulysse
Copy link
Member Author

Yes, just need to remove this profile in demultiplex

@jfy133
Copy link
Member

jfy133 commented May 22, 2024

OK, will keep open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet Awaiting requested review from ggabernet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is aws_tower config superfluous?
2 participants
@maxulysse @jfy133