-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): Add an isKeyboardNavigationDisabled prop to disable the navigation #3735
base: canary
Are you sure you want to change the base?
fix(table): Add an isKeyboardNavigationDisabled prop to disable the navigation #3735
Conversation
🦋 Changeset detectedLatest commit: 87335e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update introduces a new prop, Changes
Assessment against linked issues
Tip Announcements
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (4)
Additional comments not posted (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
I think a better solution is to automatically disable keyboard navigation temporarily when the focus is on the input, so that can move the cursor with the keyboard and use the Tab key to navigate to other elements of the table after leaving the input. |
Thanks for the suggestion @AnYiEE. But I do not think it would be a great idea to write in a logic that checks if component is input component then stop the keyboard navigation. any thoughts here @wingkwong, should we go forward with adding the prop to the |
@macci001 Is it not merge yet? I need this option :( |
@wingkwong can I please get in some review here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, I think it would be best to add an edit mode to the table. Since the React Spectrum team is working on this, we can either wait for them to fix it or implement it ourselves.
Reflecting on your comment @ryo-manba
Note 1: For navigation between focusable children of the cell, Note 2: For now, the |
@macci001 |
Closes #3681
📝 Description
⛳️ Current behavior (updates)
Screen.Recording.2024-09-10.at.4.11.24.PM.mov
🚀 New behavior
isKeyboardNavigationDisabled
prop to disable the navigation through keyboard.Screen.Recording.2024-09-10.at.4.26.36.PM.mov
💣 Is this a breaking change (Yes/No): No
Additional info
Summary by CodeRabbit
New Features
isKeyboardNavigationDisabled
prop for the Table component, allowing users to disable keyboard navigation when interacting with components that require arrow key inputs.Documentation
isKeyboardNavigationDisabled
prop.Tests
isKeyboardNavigationDisabled
prop, ensuring keyboard navigation is disabled when the prop is set to true.