Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] nmc/3185-Encrypt-Socket-Request-Fix #278

Closed
wants to merge 7 commits into from

Conversation

memurats
Copy link

@memurats memurats commented Aug 5, 2024

when receiving a shell integration socket command for ENCRYPT, a generic interface and generic code paths was used

the assumption was that the listener socket would need (and remain) valid while hanlding teh request

some code paths need to display error messages to the user via a QMessageBox

the issue is that this will execute a Qt event loop that will handle the socket disconnection while the socket variable from the caller seems it will stay valid and alive

prevent that by not using a blocking method invocation such that life time mishandling about the socket listener is not possible

@memurats memurats added custom MagentaCLOUD customisation approved build-ready Include into custom client build labels Aug 5, 2024
@memurats memurats self-assigned this Aug 5, 2024
@memurats memurats removed custom MagentaCLOUD customisation approved build-ready Include into custom client build labels Aug 13, 2024
@memurats memurats closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants