Ignore python files introduced by libpython-clj #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return nil. This change fixes https://github.com/philippkueng/clerk-issue-531 and most likely will address nextjournal#531 too.
|
Forgot to mention, here's the reproduction of the issue: https://github.com/philippkueng/clerk-issue-531 |
|
Hi maintainers of clerk, I've been wondering if you had a chance to look at the PR? If so, are you not happy with the proposed solution or the use-case it's trying solve for or something else? I'd be totally happy adapt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with Clojure, Clerk and OpenCV I noticed that while requiring a python library works as soon as one is invoking a function it'll report an error in Clerk.
I've extended the file parsing function adding a special case for python files to ignore them, similar to how markdown files are treated specially.
Let me know if you'd like to see anything else to have this change merged.