build(deps): cleanup composer #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduce from two composer files to one - thus removed 3rdparty dir - thus not commit vendor files anymore Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
3. to review
dependencies
AndyScherzinger
approved these changes
Nov 25, 2024
hweihwang
approved these changes
Nov 26, 2024
|
tests unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make the app more streamlined with others. Also, updated to 3rdparty needed manually committing vendors and last time the test did not catch it. So why bother. Smaller, simpler, better.