Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to using HTTP attributes #959

Closed
wants to merge 2 commits into from
Closed

chore: migrate to using HTTP attributes #959

wants to merge 2 commits into from

Conversation

edward-ly
Copy link
Contributor

No description provided.

julien-nc
julien-nc reviewed Oct 14, 2024
View reviewed changes
lib/Controller/ApiController.php
Comment on lines +70 to +71
#[NoCSRFRequired]
#[FrontpageRoute(verb: 'POST', url: '/user')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoCSRFRequired is only there since 27 and FrontpageRoute since 29. This app supports NC 26. We can switch to method attributes when we drop support for NC 26.

@julien-nc julien-nc closed this Oct 14, 2024
@edward-ly edward-ly deleted the fix/http-attributes branch October 14, 2024 16:39
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc left review comments

Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edward-ly @julien-nc