Make audience and azp checks optional #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julien-nc I think that its good, offers the most flexibility. Do you know why they have to be hardcoded in config.php and can't be set with |
juliusknorr
reviewed
Aug 21, 2024
| if ( | ||
| (is_string($tokenAudience) && $tokenAudience !== $providerClientId) | ||
| $checkAudience = !isset($oidcSystemConfig['login_validation_audience_check']) | ||
| || !in_array($oidcSystemConfig['login_validation_audience_check'], [false, 'false', 0, '0'], true); |
There was a problem hiding this comment.
I'd say it is also fine to just support actual boolean values, but fine with me 😁
juliusknorr
approved these changes
Aug 21, 2024
|
@juliushaertl wdyt when will this be integrated? Any idea of the timing for the next release? |
…er token Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/optional-aud-azp-checks
branch
from
4630759
to
0f31b58
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make audience and azp checks optional when logging in or validating a bearer token.
refs #856
closes #918
@col-panic Until the azp check is clarified, I think it's enough to be able to disable aud and azp checks independently during login or NC API requests bearer token validation. Wdyt?