Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting avatar on login #838

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix setting avatar on login #838

merged 3 commits into from
Jul 23, 2024

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Apr 17, 2024

  • bump min NC version to 26 to make sure Php >= 8.0 and we get str_starts_with
  • bump app version to 6.0.0 because we dropped compatibility with NC 25
  • add support for avatar URL and base64
    • URL: content is downloaded and avatar is set on the fly
    • base64: support strings which begin with data:image/png;base64, and data:image/jpeg;base64,
  • mention avatar support and details in the README

@juliushaertl What do you think about supporting URLs, in terms of security?

closes #835

@juliusknorr
Copy link
Member

What do you think about supporting URLs, in terms of security?

I'd say this is fine as long as it requires configuring the avatar mapping. In that case the source would need to be somewhat trusted by the admin, but I'd say this is something we can require the admin of the Nextcloud/IdP to consider during configuration.

@konradmoesch
Copy link

Is there anything still to be done that I can help with? For me, this PR looks complete.

@andrevmatos
Copy link

This would be a great improvement, also to work with Authentik's user avatar file upload which becomes base64 urls

@julien-nc julien-nc removed the request for review from nc-fkl July 23, 2024 10:56
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the fix/835/set-avatar-on-login branch from 85f8bf4 to 5ae5b98 Compare July 23, 2024 11:01
@julien-nc julien-nc merged commit c89d2b3 into main Jul 23, 2024
38 checks passed
@julien-nc julien-nc deleted the fix/835/set-avatar-on-login branch July 23, 2024 11:07
@julien-nc julien-nc mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar not set when logging in
4 participants