Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): user get null check #789

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(login): user get null check #789

merged 1 commit into from
Feb 6, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 6, 2024

Nachricht: OCA\UserOIDC\Service\LdapService::isLdapDeletedUser(): Argument #1 ($user) must be of type OCP\IUser, null given, called in /var/www/nextcloud/apps/user_oidc/lib/Controller/LoginController.php on line 506 in file '/var/www/nextcloud/apps/user_oidc/lib/Service/LdapService.php' line 47
Datei: /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php
Zeile: 169

Trace
#0 /var/www/nextcloud/lib/private/AppFramework/App.php(183): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\UserOIDC\Controller\LoginController), 'code')
#1 /var/www/nextcloud/lib/private/Route/Router.php(315): OC\AppFramework\App::main('OCA\\UserOIDC\\Co...', 'code', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#2 /var/www/nextcloud/lib/base.php(1068): OC\Route\Router->match('/apps/user_oidc...')
#3 /var/www/nextcloud/index.php(38): OC::handleRequest()
#4 {main}

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv self-assigned this Feb 6, 2024
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder why Psalm didn't report that as an error. It's listed as INFO: PossiblyNullArgument.

@skjnldsv skjnldsv merged commit bd218e9 into main Feb 6, 2024
38 checks passed
@skjnldsv skjnldsv deleted the fix/null-user branch February 6, 2024 11:36
@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 6, 2024

Thanks! I wonder why Psalm didn't report that as an error. It's listed as INFO: PossiblyNullArgument.

Good question, I wonder if psalm really runs here 🙈

@julien-nc julien-nc mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants