increased column length for id and secret

[nc-fkl]

closes #405
Increased column limit to 2048 for client_secret and client_id as there is no specified max length in https://www.rfc-editor.org/rfc/rfc6749

[julien-nc]

Nice!
It would be nice to show the max length in the settings labels and to limit the input fields.

[julien-nc]

Also, maybe you forgot to sign your commit. To make sure i never forget, I have this alias in my ~/.gitconfig:

[alias]
    co = commit -s

So I always do git co instead of git commit.

Also, check the failing Lint / cs php7.4 CI check. It tells you exactly what to adjust.

[julien-nc]

🏓 😁

[nc-fkl]

🏓 😁

🏓pong

[julien-nc]

Suggested change

	if ($table->hasColumn('client_secret')) {
	$column = $table->getColumn('client_secret');
	$column->setLength(2048);
	$column = $table->getColumn('client_id');
	$column->setLength(2048);
	$schemaChanged = true;
	}
	if ($table->hasColumn('client_secret')) {
	$column = $table->getColumn('client_secret');
	$column->setLength(2048);
	$schemaChanged = true;
	}
	if ($table->hasColumn('client_id')) {
	$column = $table->getColumn('client_id');
	$column->setLength(2048);
	$schemaChanged = true;
	}

Also, schemaChanged is not initialized (to false).

[julien-nc]

schemaChanged is still not initialized 😁

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!