fix sso redirect when redirectUrl is null

Signed-off-by: Julien Veyssier <[email protected]>
nextcloud · Jan 16, 2024 · dd9d580 · dd9d580
1 parent 7c90c0d
commit dd9d580
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
@@ -105,7 +105,10 @@ private function registerRedirect(IRequest $request, IURLGenerator $urlGenerator
 			// if the login page's redirect_url GET param is the logout page, just use the base URL instead
 			$logoutUrl = $urlGenerator->linkToRoute('core.login.logout');
 			$userOidcLogoutUrl = $urlGenerator->linkToRoute(self::APP_ID . '.login.singleLogoutService');
-			if (strpos($redirectUrl, $logoutUrl) !== false || strpos($redirectUrl, $userOidcLogoutUrl) !== false) {
+			if (
+				$redirectUrl
+				&& (strpos($redirectUrl, $logoutUrl) !== false || strpos($redirectUrl, $userOidcLogoutUrl) !== false)
+			) {
 				$redirectUrl = $urlGenerator->getBaseUrl();
 			}
 			$targetUrl = $urlGenerator->linkToRoute(self::APP_ID . '.login.login', [