Merge pull request #969 from nextcloud/artonge/fix/providerClientId

fix: Ensure $providerClientId is declare
nextcloud · Oct 22, 2024 · bdc807d · bdc807d
2 parents 647dae6 + 86641bb
commit bdc807d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/User/Validator/SelfEncodedValidator.php b/lib/User/Validator/SelfEncodedValidator.php
@@ -88,9 +88,9 @@ public function isValidBearerToken(Provider $provider, string $bearerToken): ?st
 		$oidcSystemConfig = $this->config->getSystemValue('user_oidc', []);
 		$checkAudience = !isset($oidcSystemConfig['selfencoded_bearer_validation_audience_check'])
 			|| !in_array($oidcSystemConfig['selfencoded_bearer_validation_audience_check'], [false, 'false', 0, '0'], true);
+		$providerClientId = $provider->getClientId();
 		if ($checkAudience) {
 			$tokenAudience = $payload->aud;
-			$providerClientId = $provider->getClientId();
 			if (
 				(is_string($tokenAudience) && $tokenAudience !== $providerClientId)
 					|| (is_array($tokenAudience) && !in_array($providerClientId, $tokenAudience, true))