Removed unnecessary lines and added error reporting

Signed-off-by: Florian Klinger <[email protected]>

lib/Controller/SettingsController.php

@@ -38,6 +38,7 @@
 use OCP\IRequest;
 use OCP\Security\ICrypto;
 use OCP\Http\Client\IClientService;
+use Psr\Log\LoggerInterface;
 
 class SettingsController extends Controller {
 
@@ -51,22 +52,26 @@ class SettingsController extends Controller {
 	private $crypto;
 	/** @var IClientService */
 	private $clientService;
+	/** @var ILogger */
+	private $logger;
 
 	public function __construct(
 		IRequest $request,
 		ProviderMapper $providerMapper,
 		ID4MeService $id4meService,
 		ProviderService $providerService,
 		ICrypto $crypto,
-		IClientService $clientService
-		) {
+		IClientService $clientService,
+		LoggerInterface $logger
+	) {
 		parent::__construct(Application::APP_ID, $request);
 
 		$this->providerMapper = $providerMapper;
 		$this->id4meService = $id4meService;
 		$this->providerService = $providerService;
 		$this->crypto = $crypto;
 		$this->clientService = $clientService;
+		$this->logger = $logger;
 	}
 
 	public function isDiscoveryEndpointValid($url) {
@@ -97,12 +102,9 @@ public function isDiscoveryEndpointValid($url) {
 						$result['missingFields'][] = $field;
 					}
 				}
-			} else {
-				// Set isReachable to false if http code wasn't 200
-				$result['isReachable'] = false;
 			}
 		} catch (Exception $e) {
-			$result['isReachable'] = false;
+			$this->logger->error('Error - discovery endpoint validation: ' . $e);
 		}
 
 		return $result;