-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NC30 compatible #261
base: master
Are you sure you want to change the base?
Make NC30 compatible #261
Conversation
Make the app compatible with Nextcloud 30 Signed-off-by: Ralf <[email protected]>
Hi @violoncelloCH , could you please just merge this and do a quick release for the App Store? My 2ct about not being able to test properly: People depending on this plugin should really have a test install they can update to NC30 and check if it still works for them. Perhaps mention that in the release note. |
Or @nickvergessen @ChristophWurst could perhaps? |
I'm not affiliated with the app. |
I'm sorry about mentioning you then, I thought you were. |
Maybe @violoncelloCH could add some extra reviewers with write access? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good
Gentle bump up. The request has been approved by @ChristophWurst . @violoncelloCH , do you need to approve it as well? Can it be merge? We have a bunch of instances to upgrade but are stocked because of user external. Thank you so much! |
Make the app compatible with Nextcloud 30
Fixes #260
Changes proposed in this pull request: