Skip to content

Commit

Permalink
Revert "chore(deps): add ramsey/uuid again for db migrations"
Browse files Browse the repository at this point in the history
This reverts commit e6aeaf3.
  • Loading branch information
st3iny committed Apr 22, 2024
1 parent 9c63410 commit 6b4e2ee
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 234 deletions.
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"php": ">=8.1.0",
"ext-json": "*",
"bamarni/composer-bin-plugin": "^1.8.2",
"ramsey/uuid": "^3.9",
"web-auth/webauthn-lib": "^4.8.5"
},
"require-dev": {
Expand Down
231 changes: 1 addition & 230 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions lib/Service/U2FMigrator.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
namespace OCA\TwoFactorWebauthn\Service;

use OCA\TwoFactorWebauthn\Db\Registration;
use Symfony\Component\Uid\Uuid;
use Ramsey\Uuid\Uuid;
use Ramsey\Uuid\UuidInterface;
use Webauthn\AttestationStatement\AttestationStatement;
use Webauthn\PublicKeyCredentialDescriptor;
use Webauthn\PublicKeyCredentialSource;
Expand All @@ -42,8 +43,8 @@ private function base64_urlsafe_decode(string $data) {
return base64_decode(str_replace(['-', '_'], ['+', '/'], $data));
}

private function zeroUuid(): Uuid {
return Uuid::fromRfc4122('00000000-0000-0000-0000-000000000000');
private function zeroUuid(): UuidInterface {

Check failure on line 46 in lib/Service/U2FMigrator.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis dev-master

UndefinedClass

lib/Service/U2FMigrator.php:46:31: UndefinedClass: Class, interface or enum named Ramsey\Uuid\UuidInterface does not exist (see https://psalm.dev/019)
return Uuid::fromString('00000000-0000-0000-0000-000000000000');

Check failure on line 47 in lib/Service/U2FMigrator.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis dev-master

UndefinedClass

lib/Service/U2FMigrator.php:47:10: UndefinedClass: Class, interface or enum named Ramsey\Uuid\Uuid does not exist (see https://psalm.dev/019)
}

public function migrateU2FRegistration(Registration $registration): PublicKeyCredentialSource {
Expand Down

0 comments on commit 6b4e2ee

Please sign in to comment.