Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/session api tests #6473

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix/session api tests #6473

wants to merge 3 commits into from

Conversation

max-nextcloud
Copy link
Collaborator

Bring back session api test

  • test(api): use cypress aliases in SessionApi spec
  • fix(test): ignores steps stored after close cleaned up

@max-nextcloud
test(api): use cypress aliases in SessionApi spec
a94e23a 
Signed-off-by: Max <[email protected]>
@max-nextcloud
fix(test): ignores steps stored after close cleaned up
a6c13a0 
We again send the initial content out,
even if there are steps.

See d2235d2.

Signed-off-by: Max <[email protected]>
@max-nextcloud
refactor(WebSocketPolyfill): cleanup redundant open handling
22f72b8 
Remove return value from `syncService.open`
and redundant handler in `WebSocketPolyfill`.

`syncService.open` triggers `opened` and `loaded` events
which both set the `version` and `session`.

Signed-off-by: Max <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@max-nextcloud