refactor(ActionList): use bool data hasEnabledChild #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if there is any child that is enabled. This is somewhat simpler than storing an array of the disabled children and comparing it's length to the length of the array of non-seperator children. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
tweak-disable-callouts
branch
from
5ed950b
to
3cd614c
Compare
luka-nextcloud
approved these changes
Apr 30, 2024
max-nextcloud
merged commit daab3ce
into
disable-callouts-button-when-all-variants-disabled
60 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if there is any child that is enabled.
This is somewhat simpler than storing an array of the disabled children and comparing it's length to the length of the array of non-seperator children.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)